feat: move durable runtime state to user data directories - #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rove state pathsand conservative dry-run/apply/prune migration with locks, journals, SQLite snapshots, conflict backup, symlink/reparse fail-closed checks, and safe recoveryROVE_DATA_ROOTvalues and update current runtime/design/operator documentationVerification
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace -j 1— all package, integration, and doc tests passedcargo test -p rove-app-bootstrap --test state_migration -- --nocapture— 23 passedscripts/state-migration-smoke.ps1 -CargoRoot ""— 19/19 under PowerShell 7powershell -ExecutionPolicy Bypass -File scripts/state-migration-smoke.ps1 -CargoRoot ""— 19/19 under Windows PowerShell 5.1pnpm test(241),pnpm typecheck,pnpm build,pnpm test:e2e(56 passed; 5 real-API-gated cases skipped in the mocked run)local-full— all 5 live real-API Playwright cases passedgit diff --checkand changed-Markdown link/fence/heading auditThe first default-parallel workspace test attempt hit the Windows linker shared PDB ceiling (
LNK1318: PDB LIMIT (12)) without a Rust assertion failure. The authoritative serial rerun above completed with exit code 0.Unverified optional gates