Skip to content

Conversation

@njmei
Copy link
Collaborator

@njmei njmei commented Oct 20, 2025

No description provided.

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.96%. Comparing base (0591f2b) to head (4c842a6).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   91.00%   90.96%   -0.04%     
==========================================
  Files          26       26              
  Lines        1434     1428       -6     
  Branches      122      122              
==========================================
- Hits         1305     1299       -6     
  Misses         98       98              
  Partials       31       31              
Files with missing lines Coverage Δ
src/aibs_informatics_aws_lambda/common/handler.py 94.78% <ø> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@njmei njmei force-pushed the add-docstring-for-lambdahandler branch from bd270ca to 8d1a758 Compare October 20, 2025 23:03
Copy link
Collaborator

@rpmcginty rpmcginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor comment but thanks for adding!

@dataclass
class MyCustomLambdaHandler(LambdaHandler[MyLambdaRequestModel, MyLambdaResponseModel]):
def handle(self, request: MyLambdaRequestModel) -> MyLambdaResponseModel:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just add the example handle method filled out here to explain all that needs to be implemented.

@njmei njmei force-pushed the add-docstring-for-lambdahandler branch from 8d1a758 to 4c842a6 Compare October 21, 2025 17:39
@njmei njmei merged commit 7c37b91 into main Oct 21, 2025
8 checks passed
@njmei njmei deleted the add-docstring-for-lambdahandler branch October 21, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants