-
Notifications
You must be signed in to change notification settings - Fork 3
Add tailmessage and advance configuration examples #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I think I've covered all of the comments at this point. Round 2 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting closer! :)
docs/adv-topics/tailmessage.md
Outdated
## Standard Tail Message Configuration | ||
|
||
### tailmessagelist= | ||
Found in `rpt.conf`, this option allows a comma-separated list of audio files to be specified for the tail message function. The tail messages will *rotate* from one to the next until the end of the list is reached, at which point the first message in the list will be selected. If no absolute path name is specified, the directory `/usr/share/asterisk/sounds/en` will be searched for the sound file. If `sounds_search_custom_dir = yes` in the `asterisk.conf` file, `/usr/share/asterisk/sounds/custom` will also be searched. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found in [`rpt.conf`](../config/rpt_conf.md#tailmessagelist), this option...
That will give you a link to the tailmessagelist
option in rpt.conf
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping for more like an iframe
type of render at the parameters. Let's see what everyone thinks of this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK - found the include-markdown
plug-in that is allows sharing the information on 2 pages yet having one source of truth. Let me know if you agree or not on how this works...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK - found the
include-markdown
plug-in that is allows sharing the information on 2 pages yet having one source of truth. Let me know if you agree or not on how this works...
I'm going to defer that to Allan for comment. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re: include-markdown
Yes, it looks like this will allow one to share/pull content from one page into another. My fear is what happens to the document when one changes the start/end content (like what happens when the start text exists but the end text is missing or modified from what was specified)?
The other option would be to stick with references ... but that has you jumping around between pages (unless you have the links open in a new window/tab).
In the end, the question is whether we want to have the details in two (or more) places. If so, include-markdown
makes sense. And, if we follow this path then maybe we think about a convention where the referenced content calls out the pages making the reference ("this section is being imported into ...").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can "easily" search for the tags to find "where" the "stuff' is between tags. Of course one needs to know the architecture. If we just want links, that's fine with me (easy enough to "undo"). I do feel like it's easier to "read" with the info right there on the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about leaving a reference at the source so that we don't remove it without dealing with the places where we have references
... and I support not having to jump around.
To check how it renders, see https://github.com/AllStarLink/ASL3-Manual#Setup-the-ASL3-Manual-Repo and then run |
Sure thing - what stinks is that github view file does NOT render the same. Now I know :) |
I use a Markdown editing application that provides a reasonable rendering ... but it's not exact. For that reason, I tend to look over any changes rendered by |
NOTE: we should hold off merging this PR until after the app_rpt changes have been released |
Fix spelling errors
Something like this for PR AllStarLink/app_rpt#688