Allow tooltip formatting the CPU module.#4724
Merged
Merged
Conversation
|
@Alexays 🙏 |
The tooltip selection block redundantly reassigned tooltip_format to config_["tooltip-format"], overwriting the state-specific format (and emptying it when no global tooltip-format was set). A lone tooltip-format-<state> therefore produced an empty tooltip. Consolidate the tooltip handling into a single block that prefers tooltip-format-<state>, falls back to the global tooltip-format, then to the computed default tooltip, reusing the existing format arg store.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes handling of
tooltip-formatwithin the CPU module.Closes #2320
Currently, when tooltip is enabled for the CPU module, each core along with its usage is listed (as well as the total).
This change allows specifying any (or none) of the format replacements of waybar-cpu(5) in the
tooltip-format.It defaults to the current behaviour (i.e., when
tooltipistrueand notooltip-formatis specified).