Show passive progress for automatic backup retries - #4
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 050e060738
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @"retryRunning": retryRunning ? @"1" : @"0", | ||
| @"progressVisible": retryRunning ? @"1" : @"0", | ||
| @"progressLabel": retryRunning ? T(language, @"automaticRetryRunning") : @"", |
There was a problem hiding this comment.
When an ordinary scheduled or mount-triggered backup is running, its validated durable progress is passed into this method, but every progress field is suppressed because retryRunning only accepts schedule-retry. Consequently, the overview and menu bar remain at the generic running state for the other headless modes even though the backup script publishes their live progress; base visibility on any supported running headless trigger and reserve the retry-specific wording for retries.
Useful? React with 👍 / 👎.
| if parse_rclone_progress_fields "$line"; then | ||
| write_progress "$label" "$RCLONE_PROGRESS_PERCENT" "$RCLONE_PROGRESS_DETAIL" "$phase" |
There was a problem hiding this comment.
When a normal copy has most recently published (for example) 100% and a duplicate-name collision then starts one of the run_rclone_with_progress "$label (ID-Archiv)" calls, durable progress is not reset at that transition and is updated only after another parseable stats line reaches this branch. The backend copyid paths use the default one-minute stats interval rather than RCLONE_OPTS, so a large duplicate can appear complete for up to a minute—and a shorter one for its entire archive copy—contrary to the new no-stale-percentage behavior. Publish an indeterminate phase record whenever each wrapped rclone operation starts.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation