Make backup failures visible and retry transient NAS reads - #2
Merged
Conversation
AlexanderSmyslowski
marked this pull request as ready for review
July 29, 2026 18:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
destination_unreadableexactly once after 30 minutes, using the existing bounded NAS retry flow.Root cause
The scheduled 20:00 run failed during the fail-closed NAS codec-manifest read check. macOS accepted the resulting notification but muted its banner and sound because Do Not Disturb was active. The retry policy announced/retried only mount availability failures, even though
destination_unreadableis also a read-only preflight failure that is safe to recheck later.User impact
Future automatic failures are eligible for Time Sensitive presentation during Focus while remaining non-modal and fullscreen-safe. A transient NAS destination read failure now receives one delayed retry and an alert that states a retry is planned.
Validation
make testsuite passed.packaging/verify-pkg.sh --expect-unsignedpassed.scripts/validate-release.sh v2.4.1passed.