feat(ec2): enabling features for ipv6 and dualstack support with corresponding unit tests #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderJangAMZN
changed the title
daniilmc
reviewed
Mar 19, 2025
| const stack = new Stack(); | ||
| const vpc = new Vpc(stack, 'VpcNetwork'); | ||
|
|
||
| // Invalid Combinations of ipAddressType and dnsRecordIpType |
| }).toThrow() | ||
| }); | ||
|
|
||
| test.each([ |
There was a problem hiding this comment.
For this test case we can remove the each and just test on one mismatch like IPv4 and Ipv6. Otherwise what we're doing here is testing js === on all potential values
AlexanderJangAMZN
force-pushed
the
ipv6-dualstack-vpc-endpoints
branch
from
66b5df4 to
3222b32
Compare
AlexanderJangAMZN
changed the title
AlexanderJangAMZN
changed the title
AlexanderJangAMZN
force-pushed
the
ipv6-dualstack-vpc-endpoints
branch
from
3222b32 to
d19a01f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling features for ipv6 and dualstack support with corresponding unit tests
Issue #33493
aws/aws-cdk#33493
Closes #33493
Reason for this change
Currently, AWS Services, i.e., Xray, Wafv2, Workmail, have started to release support for IPv6 or Dualstack for their VPC endpoints. We would like to modify our infrastructure to be able to support. these new IP address types.
Description of changes
Description of how you validated changes
Added unit tests to cover all valid and invalid cases. Throws error when IP address types don't match.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license