Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import rule #10

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix import rule #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3efe3ee
fix
May 6, 2019
9a58983
revert formatting
May 6, 2019
30533a1
revert formatting
May 6, 2019
3cd5b26
add test
May 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rules/import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ module.exports = {
if (!Object.entries(imports)) return;

const imp = Object.entries(imports)
.filter(([importString]) => importString.includes(importPath))
.filter(([importString]) => importPath.includes(importString))
.map(([, value]) => value)
.shift();

Expand Down
37 changes: 22 additions & 15 deletions tests/rules/test_import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,31 +21,46 @@ ruleTester.run('import', rule, {
code: 'const a = require("Module")',
parser: 'babel-eslint',
options: ['path/to/Legacy'],
},
{
code: 'import a from "../../Legacy"',
parser: 'babel-eslint',
options: [{ name: 'path/to/Legacy', use: 'New' }],
},
{
code: 'import a from "Legacy"',
parser: 'babel-eslint',
options: [{ name: 'path/to/Legacy', use: 'New' }],
},
{
code: 'import a from "path/to"',
parser: 'babel-eslint',
options: [{ name: 'path/to/legacy', use: 'New' }],
}
],
invalid: [
{
code: 'import a from "Legacy"',
code: 'import a from "root/deprecated/path/to/legacy"',
parser: 'babel-eslint',
options: ['Legacy'],
options: ['root/deprecated'],
errors: [{
message: 'Module Legacy is deprecated.'
message: 'Module root/deprecated is deprecated.'
}]
},
{
code: 'import a from "Legacy"',
parser: 'babel-eslint',
options: [{ name: 'Legacy', use: 'New' }],
options: ['Legacy'],
errors: [{
message: 'Module Legacy is deprecated. Use New instead.'
message: 'Module Legacy is deprecated.'
}]
},
{
code: 'import a from "Legacy"',
parser: 'babel-eslint',
options: [{ name: 'path/to/Legacy', use: 'New' }],
options: [{ name: 'Legacy', use: 'New' }],
errors: [{
message: 'Module path/to/Legacy is deprecated. Use New instead.'
message: 'Module Legacy is deprecated. Use New instead.'
}]
},
{
Expand All @@ -56,14 +71,6 @@ ruleTester.run('import', rule, {
message: 'Module path/to/Legacy is deprecated. Use New instead.'
}]
},
{
code: 'import a from "../../Legacy"',
parser: 'babel-eslint',
options: [{ name: 'path/to/Legacy', use: 'New' }],
errors: [{
message: 'Module path/to/Legacy is deprecated. Use New instead.'
}]
},
{
code: 'var a = require("Legacy")',
options: ['Legacy'],
Expand Down