Skip to content

⚡ Bolt: Cache VideoFileClip instances for faster rendering #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alchemist-Production wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡ Bolt: Cache VideoFileClip instances for faster rendering #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-23 - MoviePy Performance Optimization
**Learning:** Instantiating `VideoFileClip` inside a loop for the same file is highly inefficient as it re-opens the file and spawns ffmpeg/ffprobe processes each time.
**Action:** Cache `VideoFileClip` instances when reusing the same video source for multiple cuts.
Binary file added __pycache__/music_video_cutter.cpython-312.pyc
View file
Open in desktop
Binary file not shown.
21 changes: 18 additions & 3 deletions music_video_cutter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,22 @@ def create_music_video(mp3_file : str, video_files : VideoList, beat_times : Bea
videos_to_close = []
target_size = None

# Cache loaded video clips to avoid re-opening files
loaded_videos = {}
for v_file in video_files:
if v_file not in loaded_videos:
try:
clip = VideoFileClip(v_file)
loaded_videos[v_file] = clip
videos_to_close.append(clip)
except Exception as e:
print(f"Warning: Could not load video {v_file}: {e}")

if not loaded_videos:
raise ValueError("No valid video files could be loaded.")

valid_video_files = [f for f in video_files if f in loaded_videos]

# Iteriere durch die Beat-Paare, um die Dauer für jeden Clip zu bestimmen.
for i in range(len(selected_beats) - 1):
# Die Zieldauer des Clips im finalen Video (synchron zum Beat).
Expand All @@ -180,9 +196,8 @@ def create_music_video(mp3_file : str, video_files : VideoList, beat_times : Bea
# Für halbe Geschwindigkeit (speed_factor=0.5) brauchen wir einen doppelt so langen Clip.
required_source_duration = final_duration * speed_factor

video_file = random.choice(video_files)
video = VideoFileClip(video_file)
videos_to_close.append(video)
video_file = random.choice(valid_video_files)
video = loaded_videos[video_file]

# Schneide einen zufälligen Ausschnitt aus dem Quellvideo in der benötigten Länge.
if video.duration >= required_source_duration:
Expand Down