Skip to content

fix: reject non-string chat message inputs safely - #59

Open
AkashKundu114 wants to merge 2 commits into
mainfrom
fix/message-validator-type-guard
Open

AkashKundu114 wants to merge 2 commits into
mainfrom
fix/message-validator-type-guard

Conversation

@AkashKundu114

@AkashKundu114 AkashKundu114 commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Return a validation error for non-string chat message values instead of raising an unhandled AttributeError.
  • Add regression coverage for null, numeric, list, and mapping inputs.

Validation

  • Added focused pytest cases in tests/core/test_validators.py.
  • Tests have not been executed in this session; please review CI before merging.

Summary by Sourcery

Validate chat message types before processing their content to prevent failures on non-string inputs.

Bug Fixes:

  • Safely reject non-string chat message values with a validation error instead of raising an unhandled exception.

Tests:

  • Add regression coverage for null, numeric, list, and mapping message inputs.

@sourcery-ai

sourcery-ai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Implementation

Reject non-string messages before calling string methods, returning a validation error instead of raising an exception.

  • backend/app/utils/validators.py L2-4

Tests

Add regression coverage for null, numeric, list, and mapping values passed to the message validator.

  • tests/core/test_validators.py L34-40

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant