Skip to content

Simplify retrieval by extracting vector search into a helper function - #195

Open
gaurigupta100 wants to merge 2 commits into
Aharshi3614:mainfrom
gaurigupta100:issue-189-simplify-retrieval
Open

Simplify retrieval by extracting vector search into a helper function#195
gaurigupta100 wants to merge 2 commits into
Aharshi3614:mainfrom
gaurigupta100:issue-189-simplify-retrieval

Conversation

@gaurigupta100

Copy link
Copy Markdown

#Summary

  • Extracted vector search logic from retrieve() into a separate _vector_search() helper.
  • Kept the retrieval behavior unchanged.
  • Improved readability and maintainability.

Fixes #189

Testing

pytest tests/test_retriever.py

Result:

12 passed

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR to DevWhisper! 🎉 A maintainer will review it soon. Make sure your PR is linked to an issue and includes the ECSoC26 label before merging.

@Aharshi3614

Copy link
Copy Markdown
Owner

@gaurigupta100 Please resolve the merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify Retrieval Pipeline Execution

2 participants