Making start-docker Contract-Agnostic
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amessbee
changed the title
start-docker Contract-Agnostic --WIP--
8 tasks
toliaqat
reviewed
Sep 11, 2024
make_ports_public.sh
Outdated
| @@ -0,0 +1,19 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Why is there code related to codespaces here? That should be in a different PR to make sure that we have a shorter PR to review here.
amessbee
force-pushed
the
ms/creating-contract-agnostic-docker
branch
from
ec15741
to
1b21a98
Compare
amessbee
changed the title
start-docker Contract-Agnostic --WIP--start-docker Contract-Agnostic
|
Asking users to install |
|
I am removing myself from the review. I think @Jovonni or @mujahidkay are best suited to review and help make progress in this area. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a twin of a PR in dapp-agoric-basics repo.
Goal of this PR is to (maybe partially) close #92. Currently running of
agoriclocalchain and deploying and starting contract are intertwined in this dapp. This is somewhat unnatural as chain should not depend on the files of any specific contract - apart from the ones that designated essential for its running.Further, running a chain independent of a specific contract will allow testing of multiple dapp simultaneously running and interacting with each other which may unlock several scenarios that a developer may want to test for.
As per discussion with @toliaqat, here is a plan:
run-chain.sh) that necessary tasks for running of chain independently.yarn start:contractshould handle most of the heavy work including:ws-offer-uphere)copy tools needed for building, i.e.,Makefilecopy scripts and tools needed for required for makinginstall-bundle,submit-proposal,voteetc. calls.create contract bundles on host machine, and then copy them to the workspace in docker container.build-proposal,install-bundle,submit-proposal,voteetc. calls needed to deploy and run the contract using scripts as before.update relevant docs. In particular, add guides to installagoricandagdCLI.Link to IBIS document.