EC Changes #131
Draft
EC Changes #131
+22
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying dapp-econ-gov with
|
| Latest commit: |
7279107
|
| Status: | 🚫 Build failed. |
dckc
reviewed
Sep 19, 2024
Comment on lines
+569
to
+570
| const idA = a[0].split('-')[1]; | ||
| const idB = b[0].split('-')[1]; |
There was a problem hiding this comment.
offerIds aren't guaranteed to be of the form xxx-number. They can be any string or number.
This code has to handle offerIds from other clients.
I think filtering on instance will find the invitation you're looking for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.