chore: move PR template comment to the top #10358
Merged
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
added
the
bypass:integration
michaelfig
force-pushed
the
mfig-unbreak-pr-template
branch
from
2474df4
to
a9f2b88
Compare
Deploying agoric-sdk with
|
| Latest commit: |
2c9468a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f6623d5a.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mfig-unbreak-pr-template.agoric-sdk.pages.dev |
mhofman
approved these changes
Nov 6, 2024
If a multiline HTML comment appears after any non-whitespace, the resulting PR merge-commit will still strip it like other HTML comments, but leave behind a bunch of spurious newlines.
michaelfig
force-pushed
the
mfig-unbreak-pr-template
branch
from
a9f2b88
to
2c9468a
Compare
michaelfig
added
the
automerge:no-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incidental
Description
If an HTML comment in the PR description is multiline, Mergify will strip the text but leave the newlines behind in the resulting merge-commit comment. As a special case, remaining whitespace at the beginning of the merge-commit comment will be trimmed.
So, this PR moves the multiline "Integration testing..." comment above the "closes:" and "refs:" and "## Description" text.