Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include proposal 63 for agoric-upgrade-12 #33

Merged
merged 2 commits into from
Nov 29, 2023
Merged

include proposal 63 for agoric-upgrade-12 #33

merged 2 commits into from
Nov 29, 2023

Conversation

turadg
Copy link
Member

@turadg turadg commented Nov 29, 2023

Proposal 63 passed and executed so it should be included in proposal history.

https://bigdipper.live/agoric/proposals/63

There are no tests because I couldn't find any in https://github.com/Agoric/agoric-sdk/tree/release-mainnet1B/packages/deployment/upgrade-test/upgrade-test-scripts/agoric-upgrade-12 that weren't skipped.

@turadg turadg requested a review from mhofman November 29, 2023 17:32
turadg added a commit to Agoric/agoric-sdk that referenced this pull request Nov 29, 2023
@mhofman
Copy link
Member

mhofman commented Nov 29, 2023

There are no tests because I couldn't find any in https://github.com/Agoric/agoric-sdk/tree/release-mainnet1B/packages/deployment/upgrade-test/upgrade-test-scripts/agoric-upgrade-12 that weren't skipped.

There is only a single test in this upgrade that matters: https://github.com/Agoric/agoric-sdk/blob/26244e821f1a83cd5868f0c7d54aa480c8c17e5e/packages/deployment/upgrade-test/upgrade-test-scripts/agoric-upgrade-12/pre.test.js#L18-L27

@turadg turadg merged commit dca2e02 into main Nov 29, 2023
1 check passed
@turadg turadg deleted the upgrade-12 branch November 29, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants