Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: getRoundId #188

Merged
merged 1 commit into from
Oct 31, 2024
Merged

feat: getRoundId #188

merged 1 commit into from
Oct 31, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Oct 30, 2024

Closes #182

Trying to land @anilhelvaci 's #183 by making it a local PR.

@agoric/synthetic-chain library

  • indicate in the PR description when you expect these to be published and by whom (it's currently a manual process)

Turadg can publish this after it's passing CI.

@anilhelvaci
Copy link
Contributor

Thanks for this @turadg 🙏

Copy link
Contributor

@Chris-Hibbert Chris-Hibbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what @turadg did. What's a "local PR"?

@turadg
Copy link
Member Author

turadg commented Oct 31, 2024

What's a "local PR"?

One whose branch is in this repo. The other PR is for a branch from a fork.

@turadg
Copy link
Member Author

turadg commented Oct 31, 2024

I'm merging this but I won't cut a release just yet. I think there are some more helpers to land before going through the ceremony.

@turadg turadg merged commit d55bfe0 into main Oct 31, 2024
2 checks passed
@turadg turadg deleted the ta/get-round-id branch October 31, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a method for getting latest round id from a given price feed in synthetic-chain
3 participants