feat: Add agoric-upgrade-17 (proposal 78) #184
Conversation
proposals/78:upgrade-17/.gitignore
Outdated
| # Generated Artifacts to Ignore in CI | ||
| add-LEMONS/ | ||
| add-OLIVES/ | ||
| upgrade-bank/ | ||
| upgrade-provisionPool/ | ||
| upgrade-orch-core/ |
There was a problem hiding this comment.
I think these are generated in the agoric-sdk context but in this context, they're checked in.
| @@ -0,0 +1,208 @@ | |||
| import { | |||
There was a problem hiding this comment.
sigh. another copy of these tools. Here's hoping to migrate stuff to synthetic-chain
proposals/78:upgrade-17/README.md
Outdated
| # Proposal to upgrade the chain software | ||
|
|
||
| This reflects agoric-upgrade-17, which was adopted on mainnet by [governance | ||
| proposal 78](https://ping.pub/agoric/gov/78). |
There was a problem hiding this comment.
maybe include the date? it passed 2024-10-05
|
|
||
| import { agd, evalBundles, waitForBlock } from '@agoric/synthetic-chain'; | ||
|
|
||
| const SUBMISSION_DIR = 'localchaintest-submission'; |
There was a problem hiding this comment.
I think we need this directory populated with files that we built with a3p-integration/scripts/build-all-submissions.sh.
There was a problem hiding this comment.
Confirmed; CI got some expected errors:
PPT post {
totalMintedConverted: { brand: '$0.Alleged: IST brand', value: '+20010000' },
totalMintedProvided: { brand: '$0', value: '+2750000' },
walletsProvisioned: '+11'
}
✘ [fail]: provisionPool › upgrading provisionPool and vat-bank Rejected promise returned by test
ℹ add assets before
ℹ upgrade Bank
─
localchain › localchain passes tests
Rejected promise returned by test. Reason:
Error {
code: 'ENOENT',
errno: -2,
path: 'localchaintest-submission',
syscall: 'scandir',
message: 'ENOENT: no such file or directory, scandir \'localchaintest-submission\'',
}
provisionPool › upgrading provisionPool and vat-bank
Rejected promise returned by test. Reason:
Error {
code: 'ENOENT',
errno: -2,
path: 'upgrade-bank',
syscall: 'scandir',
message: 'ENOENT: no such file or directory, scandir \'upgrade-bank\'',
}
| const NULL_UPGRADE_BANK_DIR = 'upgrade-bank'; | ||
| const UPGRADE_PP_DIR = 'upgrade-provisionPool'; | ||
| const ADD_LEMONS_DIR = 'add-LEMONS'; | ||
| const ADD_OLIVES_DIR = 'add-OLIVES'; |
There was a problem hiding this comment.
likewise I think we need these directories populated.
| @@ -0,0 +1,166 @@ | |||
| /** | |||
| * @file work-around: importing @agoric/synthetic-chain hangs XXX | |||
There was a problem hiding this comment.
??? I wonder what that's about.
But I guess it passed review in agoric-sdk, so... oh well.
Created by following
https://github.com/Agoric/agoric-sdk/tree/agoric-upgrade-17/a3p-integration/proposals#migrate-the-proposal for https://ping.pub/agoric/gov/78
This PR currently copies
a:upgrade-17but nots:stake-bldorz:acceptance, which per CONTRIBUTING.md I think should instead move to a3p-integration/z:acceptance.I admit to a lack of understanding in how the transfer for this upgrade should proceed, and will update instructions based on review feedback.