Foreign keys migration name #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catch up
…to Agontuk-master
Agontuk
reviewed
May 31, 2021
| $schemaPart = $classPart = ''; | ||
|
|
||
| if ($schemaName) { | ||
| $schemaPart = '_for_' . str_replace(' ', '_', $schemaName); |
There was a problem hiding this comment.
Maybe we need to convert $schemaName to lowercase here in case anyone provides uppercase name.
|
good point.
Noud
…On Mon, 2021-05-31 at 06:30 -0700, Iftekhar Rifat wrote:
@Agontuk commented on this pull request.
In src/Migrations/MigrationCreator.php:
> {
// Update time interval each time so that migration
// files are created with different timestamp.
$this->setTimeInterval($this->getTimeInterval() + 60);
- $path = $this->getDatePrefix() . '_create_foreign_keys_table.php';
+ $schemaPart = $classPart = '';
+
+ if ($schemaName) {
+ $schemaPart = '_for_' . str_replace(' ', '_', $schemaName);
Maybe we need to convert $schemaName to lowercase here in case anyone
provides uppercase name.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i use multiple packages with generated migrations.
Then the foreign key migrations are not unique, so error.
This creates the foreign keys migrations as a unique filename and class.
(there are numerous commits but the end result is just 2 files changed)