feat: add per-deposit lock-up period to liquidity pool#773
Merged
Conversation
nelly439
commented
Jun 30, 2026
nelly439
commented
Contributor
- Add DepositRecord struct to track each deposit's shares and timestamp
- Add DataKey::DepositRecords and DataKey::LockupConfig storage keys
- Add PoolError::DepositLocked typed error
- Add set_lockup_duration / get_lockup_duration admin entrypoints
- Record per-deposit timestamp in create_pool and add_liquidity (FIFO list)
- Enforce FIFO lock-up check in remove_liquidity, additive to existing minimum-liquidity threshold guard
- Add unit tests: reject before expiry, allow at expiry, partial withdrawal spanning locked and unlocked deposits, lockup config round-trip, no-lockup bypass closes liquidity_pool: Implement minimum lock-up period for newly deposited liquidity #741
- Add DepositRecord struct to track each deposit's shares and timestamp - Add DataKey::DepositRecords and DataKey::LockupConfig storage keys - Add PoolError::DepositLocked typed error - Add set_lockup_duration / get_lockup_duration admin entrypoints - Record per-deposit timestamp in create_pool and add_liquidity (FIFO list) - Enforce FIFO lock-up check in remove_liquidity, additive to existing minimum-liquidity threshold guard - Add unit tests: reject before expiry, allow at expiry, partial withdrawal spanning locked and unlocked deposits, lockup config round-trip, no-lockup bypass
|
@nelly439 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
done and pushed |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.