Mesa v25.0.1 #679
Mesa v25.0.1 #679
Conversation
|
I have some comments about this but I'm on mobile for a bit. I'll come back with proper feedback soon |
m/mesa-clc/stone.yaml
Outdated
| - optimize: speed | ||
| builddeps : | ||
| - cmake(Clang) | ||
| - binary(llvm-config32) |
There was a problem hiding this comment.
llvm-config32 is for the 32bit llvm package. You probably just want llvm-config
m/mesa-clc/stone.yaml
Outdated
| license : | ||
| - BSD-2-Clause | ||
| - MIT | ||
| #toolchain : gnu |
m/mesa-clc/stone.yaml
Outdated
| tuning : | ||
| - lto: false | ||
| - symbolic: false | ||
| - optimize: speed |
There was a problem hiding this comment.
Probably not useful, I assume you just copied these from mesa?
There was a problem hiding this comment.
Removed, worked also without it.
m/mesa-clc/stone.yaml
Outdated
| - pkgconfig(SPIRV-Tools) | ||
| - pkgconfig(libclc) | ||
| - pkgconfig(libdrm) | ||
| - pkgconfig32(expat) |
There was a problem hiding this comment.
pkgconfig32 is only for when you want to pull in the 32bit version of a library (which pulls in the 64bit one transitively). Since this is not a 32bit build you should just use pkgconfig(expat)
There was a problem hiding this comment.
Changed as requested.
m/mesa-clc/stone.yaml
Outdated
| # Patch to acctually find LLVM | ||
| # %%patch %(pkgdir)/llvm.patch |
There was a problem hiding this comment.
They are gone now.
m/mesa/stone.yaml
Outdated
| -Dintel-clc=system \ | ||
| -Dvulkan-drivers=amd,intel,intel_hasvk,swrast,virtio$EXTRA_VK_DRIVERS \ | ||
| -Dvulkan-layers=device-select,overlay,screenshot | ||
| -Dvulkan-drivers=amd,gfxstream,intel,intel_hasvk,swrast,virtio$EXTRA_VK_DRIVERS \ |
There was a problem hiding this comment.
As discussed on Matrix remove gfxstream from here and move it to the EXTRA_VK_DRIVERS section on line 87.
m/mesa/stone.yaml
Outdated
| -Dvulkan-drivers=amd,intel,intel_hasvk,swrast,virtio$EXTRA_VK_DRIVERS \ | ||
| -Dvulkan-layers=device-select,overlay,screenshot | ||
| -Dvulkan-drivers=amd,gfxstream,intel,intel_hasvk,swrast,virtio$EXTRA_VK_DRIVERS \ | ||
| -Dvulkan-layers=device-select,intel-nullhw,overlay,screenshot,vram-report-limit |
There was a problem hiding this comment.
intel-nullhw is really only for driver devs and is unnecessary for us.
| # | ||
| # SPDX-License-Identifier: MPL-2.0 | ||
| # | ||
| name : intel-clc |
There was a problem hiding this comment.
There's a removals.md in the project root, can you add intel-clc and intel-clc-dbginfo to it with a description of why they're being deprecated?
There was a problem hiding this comment.
Added to the removals.md
| @@ -4,11 +4,11 @@ | |||
| # SPDX-License-Identifier: MPL-2.0 | |||
| # | |||
| name : mesa | |||
| version : 24.3.4 | |||
| release : 30 | |||
| version : 25.0.1 | |||
There was a problem hiding this comment.
Can you add a note here that mesa-clc should be kept in sync with mesa version-wise?
There was a problem hiding this comment.
Why not find a way in tooling to allow 64bit split packages for 32bit base packages so all is in one spec?
There was a problem hiding this comment.
So you want to make it so that we build mesa in one recipe and cross-compile within the same recipe? It's certainly possible but I suspect that it'll be more annoying to setup than just having a split out mesa-clc package.
- replaced by mesa-clc
Note: if intel-clc was only used for compiling intel drivers in Mesa, that can be dropped.