Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easyeffects: Add at version 7.2.3 #670

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

Vixea
Copy link
Contributor

@Vixea Vixea commented Feb 26, 2025

No description provided.

@Vixea Vixea requested a review from a team as a code owner February 26, 2025 04:04
Copy link
Member

@ReillyBrogan ReillyBrogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I'll have more review comments, but I wasn't able to build fftw with the following error:

│B│ if (/bin/sh '/mason/build/x86_64/fftw-3.3.10.tar.gz/.fftw/missing' makeinfo --version) >/dev/null 2>&1; then \
│B│   for f in fftw3.info fftw3.info-[0-9] fftw3.info-[0-9][0-9] fftw3.i[0-9] fftw3.i[0-9][0-9]; do \
│B│     if test -f $f; then mv $f $backupdir; restore=mv; else :; fi; \
│B│   done; \
│B│ else :; fi && \
│B│ cd "$am__cwd"; \
│B│ if /bin/sh '/mason/build/x86_64/fftw-3.3.10.tar.gz/.fftw/missing' makeinfo   -I . \
│B│  -o fftw3.info fftw3.texi; \
│B│ then \
│B│   rc=0; \
│B│   CDPATH="${ZSH_VERSION+.}:" && cd .; \
│B│ else \
│B│   rc=$?; \
│B│   CDPATH="${ZSH_VERSION+.}:" && cd . && \
│B│   $restore $backupdir/* `echo "./fftw3.info" | sed 's|[^/]*$||'`; \
│B│ fi; \
│B│ rm -rf $backupdir; exit $rc
│B│ /mason/build/x86_64/fftw-3.3.10.tar.gz/.fftw/missing: line 81: makeinfo: command not found
│B│ WARNING: 'makeinfo' is missing on your system.
│B│          You should only need it if you modified a '.texi' file, or
│B│          any other file indirectly affecting the aspect of the manual.
│B│          You might want to install the Texinfo package:
│B│          <https://www.gnu.org/software/texinfo/>
│B│          The spurious makeinfo call might also be the consequence of
│B│          using a buggy 'make' (AIX, DU, IRIX), in which case you might
│B│          want to install GNU make:
│B│          <https://www.gnu.org/software/make/>
│B│ make[3]: *** [Makefile:466: fftw3.info] Error 127

@Vixea Vixea force-pushed the easyeffects branch 2 times, most recently from 6fa7fb2 to 2907cdf Compare March 9, 2025 18:21
Copy link
Member

@ReillyBrogan ReillyBrogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that lsp-plugins is also missing from this. Other than those 3 things this looks good.

@Vixea
Copy link
Contributor Author

Vixea commented Mar 13, 2025

Added a patch to easyeffects that when the pipewire 1.4.0 pr lands it won't have any problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants