Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmp: Update to v6.3.0 #402

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Pheoxy
Copy link
Contributor

@Pheoxy Pheoxy commented Oct 5, 2024

Update GMP to v6.3.0

This pull request updates the GNU Multiple Precision Arithmetic Library (GMP) with the following enhancements:

Enhancements

  1. LTO (Link Time Optimization) Support:

    • Added LTO support to improve the performance and optimization of the GMP library.
  2. Additional Make Checks:

    • Included missing make check commands to ensure comprehensive testing during the build process.

@Pheoxy Pheoxy requested a review from a team as a code owner October 5, 2024 15:09
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@ReillyBrogan ReillyBrogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits should be squashed, also we recently(ish) enabled LTO by default. That flag is no longer needed if you want it to continue using thin-lto. Alternately you can switch it to full LTO with lto: full

@Pheoxy
Copy link
Contributor Author

Pheoxy commented Mar 8, 2025

Commits should be squashed, also we recently(ish) enabled LTO by default. That flag is no longer needed if you want it to continue using thin-lto. Alternately you can switch it to full LTO with lto: full

Thanks for the update. I deliberately kept the commits separate because I believe package version updates and other changes should remain distinct within the PR. Squashing them would mix these changes, making debugging more difficult later—even for a simple update like this.

Regarding the LTO flag, I appreciate the heads-up.

I don’t have the time to update this PR myself at the moment, but if someone else wants to take over, they’re welcome to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants