-
Notifications
You must be signed in to change notification settings - Fork 53
Release v10.4.1 #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Release v10.4.1 #308
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request serves as a release candidate for version 10.4.1 of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the library version to 10.4.1. The changes are straightforward and correct for a patch release. However, I've noted an opportunity to improve the release process by removing a source of duplication for the version number, which would enhance maintainability and prevent potential inconsistencies in the future.
@@ -1,2 +1,2 @@ | |||
10.4.0 | |||
10.4.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version number is defined here and also in lib/adyen/version.rb
. Having the version number in two separate places can lead to inconsistencies if one is updated and the other is forgotten. To adhere to the DRY (Don't Repeat Yourself) principle and make the release process more robust, I recommend using lib/adyen/version.rb
as the single source of truth. This VERSION
file could then be generated automatically from lib/adyen/version.rb
as part of your release script.
7e55caa
to
76d09a9
Compare
76d09a9
to
4c676e5
Compare
4c676e5
to
85a0f1e
Compare
|
Merged pull requests to be released:
Full Changelog: v10.4.0...main