Code generation: update services and models #305
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the generated code for Adyen services and models, specifically reflecting recent changes in the OpenAPI specification. The primary impact is the addition of a new API endpoint for validating shopper IDs.
Highlights
- New API Endpoint: I've added a new validate_shopper_id method to the UtilityApi service, which allows for validating shopper IDs via a POST request to the /validateShopperId endpoint.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request, generated from an OpenAPI specification, adds a new validate_shopper_id method to the UtilityApi. My review identifies a few issues in the new method. There's an unused parameter in the method signature which is confusing and should be removed. Additionally, the endpoint URL construction logic is unnecessarily complex for a static path and can be simplified. Finally, tests for the new validate_shopper_id endpoint are missing and should be added to ensure its correctness.
| end | ||
|
|
||
| # Validates shopper Id | ||
| def validate_shopper_id(request, validate_shopper_id_request, headers: {}) |
There was a problem hiding this comment.
The method validate_shopper_id includes an unused parameter validate_shopper_id_request. This makes the method signature confusing and should be removed to align with the other methods in this class.
def validate_shopper_id(request, headers: {})| endpoint = '/validateShopperId'.gsub(/{.+?}/, '%s') | ||
| endpoint = endpoint.gsub(%r{^/}, '') | ||
| endpoint = format(endpoint) |
There was a problem hiding this comment.
The construction of the endpoint string can be simplified. Since '/validateShopperId' is a static string with no path parameters, the calls to gsub and format are redundant.
endpoint = 'validateShopperId'| # Validates shopper Id | ||
| def validate_shopper_id(request, validate_shopper_id_request, headers: {}) | ||
| endpoint = '/validateShopperId'.gsub(/{.+?}/, '%s') | ||
| endpoint = endpoint.gsub(%r{^/}, '') | ||
| endpoint = format(endpoint) | ||
|
|
||
| action = { method: 'post', url: endpoint } | ||
| @client.call_adyen_api(@service, action, request, headers, @version) | ||
| end |
There was a problem hiding this comment.
The new validate_shopper_id method is not covered by any tests. Please add unit tests for this new functionality in spec/checkout_spec.rb to verify its behavior and prevent future regressions.
AdyenAutomationBot
force-pushed
the
sdk-automation/models
branch
from
d00a1e4 to
6a600c8
Compare
AdyenAutomationBot
force-pushed
the
sdk-automation/models
branch
2 times, most recently
from
05c743e to
3ee984d
Compare
AdyenAutomationBot
force-pushed
the
sdk-automation/models
branch
2 times, most recently
from
25a03e7 to
55a78dd
Compare
AdyenAutomationBot
force-pushed
the
sdk-automation/models
branch
from
55a78dd to
1701639
Compare
AdyenAutomationBot
force-pushed
the
sdk-automation/models
branch
from
1701639 to
7180ed9
Compare
|
2 participants
OpenAPI spec files or templates have been modified on 10-10-2025 by commit.