Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Guzzle utils #720

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Import Guzzle utils #720

wants to merge 1 commit into from

Conversation

szepeviktor
Copy link
Contributor

Description
GuzzleHttp\Utils is not imported but used

Tested scenarios
Running @phpstan

Fixed issue: #710

@szepeviktor szepeviktor requested a review from a team as a code owner December 12, 2024 05:22
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@szepeviktor
Copy link
Contributor Author

Maybe we should remove this line

adyen-php-api-library/templates/ObjectSerializer.mustache

Line 227 in af262a7

$data = Utils::streamFor($data);

@DjoykeAbyah
Copy link
Member

Hi @szepeviktor!

Thank you for your contribution and for pointing this out. We're reviewing it now and will get back to you shortly.

Kind regards,

Djoyke
Adyen

@szepeviktor szepeviktor marked this pull request as draft December 23, 2024 16:17
@szepeviktor
Copy link
Contributor Author

szepeviktor commented Dec 23, 2024 •
edited
Loading

I think Guzzle was removed long time ago, and this is the last remnant: so it should be deleted/replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szepeviktor @DjoykeAbyah