Reset quote reserved order ID with checkout_submit_before event

[dimitriBouteille]

Description

The objective of this PR is to improve the reset of the reserved_order_id by using the event checkout_submit_before which is called in graphQl and REST.

The plugins implemented in PR #830 do not work in graphQl.

In graphQl context, the resolver placeOrder call \Magento\Quote\Api\Data\PaymentInterface\CartManagementInterface::placeOrder() and in REST context this class is also called.

CartManagementInterface::placeOrder() function trigger checkout_submit_before.

---

Fixes #2999

[gemini-code-assist]

Summary of Changes

Hello @dimitriBouteille, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors how the reserved_order_id is handled within the Adyen payment module for Magento 2. The primary goal is to fix an inconsistency where the order ID was not being reset correctly in GraphQL checkout flows, while ensuring the behavior remains consistent with REST API checkouts. By transitioning from specific plugins to a more universal event observer, the solution provides a robust and unified mechanism for managing quote IDs before order submission, ultimately improving the checkout experience.

Highlights

• Improved Reserved Order ID Reset: The core change ensures the reserved_order_id is consistently reset for Adyen payments, specifically addressing a previous gap in GraphQL contexts where this was not happening reliably.
• Event-Driven Reset Mechanism: The previous plugin-based approach for resetting the reserved_order_id has been replaced. A new observer (ResetQuoteReservedOrderId) now listens to the checkout_submit_before event, which is triggered reliably in both REST and GraphQL checkout flows, providing a unified solution.
• Removed Obsolete Plugins: Two di.xml plugin declarations (AdyenPaymentInformationResetOrderId and GuestAdyenPaymentInformationResetOrderId) that handled the old reset logic have been removed as they are no longer needed with the new event-driven approach.
• Frontend Quote ID Handling Enhancement: A minor adjustment in the frontend JavaScript (adyen-payment-service.js) allows the paymentDetails function to optionally accept a quoteId parameter, providing more flexibility in how guest cart IDs are retrieved for payment details calls.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses the issue of resetting the reserved_order_id by migrating the logic to the checkout_submit_before event. This change correctly extends the functionality to both GraphQL and REST contexts, which is a significant improvement. The removal of the old plugins and the introduction of the new observer are well-aligned with the stated objective. The JavaScript changes also appear to be a sensible adjustment to support the new flow.

[candemiralp]

Hello @dimitriBouteille,

Thank you for your contribution. However, the above mentioned plugins to reset incrementId have successfully called on our environments. Therefore, this PR might be redundant.

I left a comment here. Let's continue discussing on the other thread.

Best Regards,
Can