[Fix] Исправление имплантов.#2799
Open
Armorkillerd wants to merge 4 commits into
Open
Conversation
Contributor
WalkthroughPR содержит баланс-патч для двух имплантов: Mantis Daggers и Sandevistan. Для Mantis Daggers уменьшены параметры EMP-активации: кулдаун с 15 до 10 секунд и длительность джиттера-эффекта с 15 до 10 секунд. Для Sandevistan добавлена проверка активного состояния перед применением EMP-логики, увеличен урон типа Shock с 30 до 40 и увеличена длительность парализации с 5 до 6 секунд. Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MinokaaUWU
requested changes
May 24, 2026
Collaborator
MinokaaUWU
left a comment
MinokaaUWU
left a comment
There was a problem hiding this comment.
В целом все гуд, но пофикси форматинг и все
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (5)
Content.Server/ADT/Sandevistan/SandevistanUserComponent.cs (1)
1-6: 🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick winНарушен алфавитный порядок using директив.
Согласно coding guidelines, в файлах /ADT/ using директивы должны быть отсортированы в алфавитном порядке. Текущий порядок нарушает это требование.
♻️ Предложенное исправление порядка using
-using Content.Shared.FixedPoint; +using Content.Shared.ADT.Abilities; using Content.Shared.ADT.Sandevistan; using Content.Shared.ADT.Trail; -using Content.Shared.ADT.Abilities; using Content.Shared.Damage; +using Content.Shared.FixedPoint; using Robust.Shared.Audio;As per coding guidelines: "И ещё смотри за тем чтобы using был в алфавитном порядке в наших /ADT/ системах и компонентах".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Content.Server/ADT/Sandevistan/SandevistanUserComponent.cs` around lines 1 - 6, The using directives at the top of SandevistanUserComponent.cs are not alphabetized; reorder the using statements in the file so they follow alphabetical order (by namespace) as required for /ADT/ systems — e.g., sort the existing directives (Content.Shared.ADT.Abilities, Content.Shared.ADT.Sandevistan, Content.Shared.ADT.Trail, Content.Shared.Damage, Content.Shared.FixedPoint, Robust.Shared.Audio) into proper alphabetical order and replace the current block in the file (the using block that includes these namespaces) with the sorted list, preserving any needed usings and removing duplicates if present.Content.Shared/ADT/Implants/Components/MantisDaggersComponent.cs (1)
1-9: 🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick winНарушен алфавитный порядок using директив.
Согласно coding guidelines, в файлах /ADT/ using директивы должны быть отсортированы в алфавитном порядке. Текущий порядок нарушает это требование.
♻️ Предложенное исправление порядка using
-using Content.Shared.Anomaly.Effects; -using Content.Shared.Body.Prototypes; using Content.Shared.Damage; +using Content.Shared.FixedPoint; using Robust.Shared.Audio; using Robust.Shared.Containers; using Robust.Shared.GameStates; using Robust.Shared.Prototypes; using Robust.Shared.Utility; -using Content.Shared.FixedPoint;As per coding guidelines: "И ещё смотри за тем чтобы using был в алфавитном порядке в наших /ADT/ системах и компонентах".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Content.Shared/ADT/Implants/Components/MantisDaggersComponent.cs` around lines 1 - 9, Using directives in MantisDaggersComponent.cs are out of alphabetical order; reorder them into strict alphabetical order (case-insensitive) so they follow the project's /ADT/ guideline — locate the using block at the top of the file in the MantisDaggersComponent (class/namespace) file and sort entries such as Content.Shared.Anomaly.Effects, Content.Shared.Body.Prototypes, Content.Shared.Damage, Content.Shared.FixedPoint, Robust.Shared.Audio, Robust.Shared.Containers, Robust.Shared.GameStates, Robust.Shared.Prototypes, Robust.Shared.Utility so the list is alphabetized.Content.Server/ADT/Implants/VisibleImplantSystem.cs (2)
7-7:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winДублирующийся using директива.
Content.Shared.Damageимпортируется дважды (строки 7 и 28). Необходимо удалить один из дубликатов.🔧 Предложенное исправление
using Content.Shared.Armor; using Content.Shared.Damage; using Content.Shared.Explosion;И удалить дубликат на строке 28:
using Content.Shared.Jittering; -using Content.Shared.Damage; using Content.Shared.Damage.Systems;Also applies to: 28-28
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Content.Server/ADT/Implants/VisibleImplantSystem.cs` at line 7, Remove the duplicate using directive for Content.Shared.Damage in the VisibleImplantSystem file: locate the top-of-file using imports in the VisibleImplantSystem class/namespace and delete the redundant "using Content.Shared.Damage;" occurrence so it only appears once among the using statements.
1-32: 🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick winНарушен алфавитный порядок using директив.
Согласно coding guidelines, в файлах /ADT/ using директивы должны быть отсортированы в алфавитном порядке. Текущий порядок значительно нарушает это требование.
♻️ Предложенное исправление порядка using
+using Content.Server.Emp; using Content.Server.Explosion.EntitySystems; using Content.Server.Stealth; using Content.Shared.Actions; +using Content.Shared.ADT.CantShoot; using Content.Shared.ADT.Crawling; using Content.Shared.ADT.Implants; using Content.Shared.Armor; using Content.Shared.Damage; +using Content.Shared.Damage.Prototypes; +using Content.Shared.Damage.Systems; +using Content.Shared.Emp; using Content.Shared.Explosion; +using Content.Shared.Interaction.Components; using Content.Shared.Inventory; +using Content.Shared.Jittering; using Content.Shared.Movement.Systems; using Content.Shared.Popups; using Content.Shared.Stealth.Components; using Content.Shared.Storage.EntitySystems; +using Content.Shared.Stunnable; using Content.Shared.Tag; +using Content.Shared.Weapons.Reflect; using Content.Shared.Weapons.Melee; using Robust.Server.Audio; using Robust.Server.GameObjects; using Robust.Shared.Containers; using Robust.Shared.Player; +using Robust.Shared.Prototypes; using Robust.Shared.Random; -using Content.Shared.Interaction.Components; using Robust.Shared.Timing; -using Robust.Shared.Prototypes; -using Content.Shared.Damage.Prototypes; -using Content.Server.Emp; -using Content.Shared.Stunnable; -using Content.Shared.Jittering; -using Content.Shared.Damage; -using Content.Shared.Damage.Systems; -using Content.Shared.Weapons.Reflect; -using Content.Shared.ADT.CantShoot; -using Content.Shared.Emp;As per coding guidelines: "И ещё смотри за тем чтобы using был в алфавитном порядке в наших /ADT/ системах и компонентах".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Content.Server/ADT/Implants/VisibleImplantSystem.cs` around lines 1 - 32, The using directives in VisibleImplantSystem (VisibleImplantSystem.cs) are out of alphabetical order and contain duplicates (e.g., Content.Shared.Damage, Content.Shared.Emp); reorder all using statements alphabetically and remove duplicate using lines so the top-of-file usings follow the project's /ADT/ alphabetical guideline (ensure the order includes Robust.*, Content.Server.*, Content.Shared.* groups sorted as strings).Content.Server/ADT/Sandevistan/SandevistanSystem.cs (1)
1-19: 🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick winНарушен алфавитный порядок using директив.
Согласно coding guidelines, в файлах /ADT/ using директивы должны быть отсортированы в алфавитном порядке. Текущий порядок нарушает это требование.
♻️ Предложенное исправление порядка using
using Content.Shared.ADT.Abilities; -using Content.Shared.ADT.Trail; using Content.Shared.ADT.Sandevistan; +using Content.Shared.ADT.Trail; using Content.Shared.Actions; using Content.Shared.Damage; using Content.Shared.Damage.Systems; -using Content.Server.Emp; +using Content.Shared.Emp; using Content.Shared.Jittering; using Content.Shared.Mobs; using Content.Shared.Mobs.Systems; using Content.Shared.Movement.Systems; using Content.Shared.Popups; using Content.Shared.Stunnable; using Content.Shared.Weapons.Melee; using Content.Shared.Weapons.Melee.Events; +using Content.Server.Emp; using Robust.Shared.Audio.Systems; using Robust.Shared.Timing; using System.Numerics; -using Content.Shared.Emp;As per coding guidelines: "И ещё смотри за тем чтобы using был в алфавитном порядке в наших /ADT/ системах и компонентах".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Content.Server/ADT/Sandevistan/SandevistanSystem.cs` around lines 1 - 19, The using directives at the top of SandevistanSystem.cs are out of alphabetical order and contain a duplicate (Content.Shared.Emp); reorder the entire using block into a single alphabetically sorted list (case-insensitive) and remove duplicates so all namespaces (e.g., Content.Shared.ADT.Abilities, Content.Shared.ADT.Sandevistan, Content.Shared.Emp, Robust.Shared.Audio.Systems, System.Numerics, etc.) appear once in proper alphabetical order.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@Content.Server/ADT/Implants/VisibleImplantSystem.cs`:
- Line 7: Remove the duplicate using directive for Content.Shared.Damage in the
VisibleImplantSystem file: locate the top-of-file using imports in the
VisibleImplantSystem class/namespace and delete the redundant "using
Content.Shared.Damage;" occurrence so it only appears once among the using
statements.
- Around line 1-32: The using directives in VisibleImplantSystem
(VisibleImplantSystem.cs) are out of alphabetical order and contain duplicates
(e.g., Content.Shared.Damage, Content.Shared.Emp); reorder all using statements
alphabetically and remove duplicate using lines so the top-of-file usings follow
the project's /ADT/ alphabetical guideline (ensure the order includes Robust.*,
Content.Server.*, Content.Shared.* groups sorted as strings).
In `@Content.Server/ADT/Sandevistan/SandevistanSystem.cs`:
- Around line 1-19: The using directives at the top of SandevistanSystem.cs are
out of alphabetical order and contain a duplicate (Content.Shared.Emp); reorder
the entire using block into a single alphabetically sorted list
(case-insensitive) and remove duplicates so all namespaces (e.g.,
Content.Shared.ADT.Abilities, Content.Shared.ADT.Sandevistan,
Content.Shared.Emp, Robust.Shared.Audio.Systems, System.Numerics, etc.) appear
once in proper alphabetical order.
In `@Content.Server/ADT/Sandevistan/SandevistanUserComponent.cs`:
- Around line 1-6: The using directives at the top of
SandevistanUserComponent.cs are not alphabetized; reorder the using statements
in the file so they follow alphabetical order (by namespace) as required for
/ADT/ systems — e.g., sort the existing directives
(Content.Shared.ADT.Abilities, Content.Shared.ADT.Sandevistan,
Content.Shared.ADT.Trail, Content.Shared.Damage, Content.Shared.FixedPoint,
Robust.Shared.Audio) into proper alphabetical order and replace the current
block in the file (the using block that includes these namespaces) with the
sorted list, preserving any needed usings and removing duplicates if present.
In `@Content.Shared/ADT/Implants/Components/MantisDaggersComponent.cs`:
- Around line 1-9: Using directives in MantisDaggersComponent.cs are out of
alphabetical order; reorder them into strict alphabetical order
(case-insensitive) so they follow the project's /ADT/ guideline — locate the
using block at the top of the file in the MantisDaggersComponent
(class/namespace) file and sort entries such as Content.Shared.Anomaly.Effects,
Content.Shared.Body.Prototypes, Content.Shared.Damage,
Content.Shared.FixedPoint, Robust.Shared.Audio, Robust.Shared.Containers,
Robust.Shared.GameStates, Robust.Shared.Prototypes, Robust.Shared.Utility so the
list is alphabetized.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: c167f3d9-3567-4fe9-95c4-0fb5e5aa5cc8
📒 Files selected for processing (4)
Content.Server/ADT/Implants/VisibleImplantSystem.csContent.Server/ADT/Sandevistan/SandevistanSystem.csContent.Server/ADT/Sandevistan/SandevistanUserComponent.csContent.Shared/ADT/Implants/Components/MantisDaggersComponent.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание PR
Сандевиндстан: Поднял урон от эми импульса, вернул проверку if на активацию санда.
Клинки богомола: Урон от эми импульса понижен, кд после эми импульса сниженно. все так же пассивно получает урон.
Почему / Баланс
Техническая информация
Медиа
Чейнджлог
🆑 Armorkillerd