Skip to content

[TWEAK] Добавление ролей шахтеров на все карты#2792

Open
Cethet wants to merge 2 commits into
AdventureTimeSS14:masterfrom
Cethet:mapminer
Open

[TWEAK] Добавление ролей шахтеров на все карты#2792
Cethet wants to merge 2 commits into
AdventureTimeSS14:masterfrom
Cethet:mapminer

Conversation

@Cethet
Copy link
Copy Markdown
Contributor

@Cethet Cethet commented May 18, 2026

Описание PR

Надо

Почему / Баланс

Техническая информация

  • Изменения были протестированы на локальном сервере, и всё работает отлично.
  • PR закончен и требует просмотра изменений.

Медиа

Чейнджлог

🆑 Cethet

  • tweak: Теперь на всех картах есть корректное число ролей шахтеров

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

Review Change Stack

Warning

Rate limit exceeded

@Cethet has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 55 minutes and 55 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 34cdddd6-d7b2-46ec-aeb6-0494d036421e

📥 Commits

Reviewing files that changed from the base of the PR and between 91ae82d and 9025287.

📒 Files selected for processing (1)
  • Resources/Prototypes/ADT/Maps/ADTMaps/adt_kerberos.yml

Walkthrough

Данный PR обновляет конфигурации 11 карт ADT-станций, добавляя или модифицируя роль ADTMiner в списке доступных профессий с различными диапазонами численности (от [2, 2] до [4, 4] в зависимости от карты). Для карты ADT_Kerberos исправлен путь файла ресурса. Дополнительно выполнена уборка пробела в комментарии конфигурации пула карт.

Possibly related PRs

Suggested labels

Changes: Map, Status: Needs Review, S: Untriaged, size/M, Changes: No C#

Suggested reviewers

  • Unlumy
  • PyotrIgn
  • Ratyyy
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Название PR чётко описывает основное изменение — добавление ролей шахтеров на все карты, что соответствует содержимому всех изменённых файлов конфигураций карт.
Description check ✅ Passed Описание PR связано с изменениями, хотя и содержит неполную информацию (секции заполнены словом «Надо»), но чейнджлог указывает на релевантные изменения шахтёрских ролей.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Resources/Prototypes/ADT/Maps/ADTMaps/adt_kerberos.yml`:
- Line 4: В файле с ключом mapPath замените неверный сегмент "6aps" на "ADTMaps"
— откройте запись mapPath в adt_kerberos.yml и исправьте значение так, чтобы
путь указывал на папку ADTMaps/ADTStations/adt_kerberos.yml (т.е. убрать "6aps"
и использовать "ADTMaps"), затем сохраните файл и проверьте загрузку карты.

In `@Resources/Prototypes/Maps/Pools/default.yml`:
- Line 52: This change modifies a YAML file outside /ADT/ without the required
marker — add an explicit ADT-Tweak annotation: for this single-line edit insert
a comment using "# ADT-Tweak: <brief reason>" immediately adjacent to the
modified line (or wrap multiple edits with "# ADT-Tweak-Start" and "#
ADT-Tweak-End"); reference the ADT-Tweak token and ensure the brief reason
explains why the change to the line "ADT_Barratry Выведена по просьбе Жабича" is
needed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 36e4ee0a-8f77-4240-b746-804dd1707c54

📥 Commits

Reviewing files that changed from the base of the PR and between 4331136 and 91ae82d.

📒 Files selected for processing (12)
  • Resources/Prototypes/ADT/Maps/ADTMaps/adt_aspid.yml
  • Resources/Prototypes/ADT/Maps/ADTMaps/adt_bagel.yml
  • Resources/Prototypes/ADT/Maps/ADTMaps/adt_box.yml
  • Resources/Prototypes/ADT/Maps/ADTMaps/adt_cluster.yml
  • Resources/Prototypes/ADT/Maps/ADTMaps/adt_fland.yml
  • Resources/Prototypes/ADT/Maps/ADTMaps/adt_kerberos.yml
  • Resources/Prototypes/ADT/Maps/ADTMaps/adt_marathon.yml
  • Resources/Prototypes/ADT/Maps/ADTMaps/adt_meta.yml
  • Resources/Prototypes/ADT/Maps/ADTMaps/adt_origin.yml
  • Resources/Prototypes/ADT/Maps/ADTMaps/adt_packed.yml
  • Resources/Prototypes/ADT/Maps/ADTMaps/adt_silly.yml
  • Resources/Prototypes/Maps/Pools/default.yml

Comment thread Resources/Prototypes/ADT/Maps/ADTMaps/adt_kerberos.yml Outdated
# - ADT_Gemini Пока Кэш не доделает
# - ADT_Cluster_Legacy Пока Кэш не сделает
# - ADT_Barratry Выведена по просьбе Жабича
# - ADT_Barratry Выведена по просьбе Жабича
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Добавьте обязательную ADT-Tweak-маркировку для изменения вне /ADT/.

Для правок в этом файле нужно явно пометить изменение через # ADT-Tweak: ... (для одиночной строки) или блок # ADT-Tweak-Start / # ADT-Tweak-End.

💡 Вариант правки
+  # ADT-Tweak: косметическая правка комментария (удален лишний пробел)
   # - ADT_Barratry Выведена по просьбе Жабича

As per coding guidelines: "**/*.yml: Все изменения вне папок /ADT/ должны быть прокомментированы ... Одиночные строки можно просто помечать как # ADT-Tweak: ...".

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# - ADT_Barratry Выведена по просьбе Жабича
# ADT-Tweak: косметическая правка комментария (удален лишний пробел)
# - ADT_Barratry Выведена по просьбе Жабича
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Resources/Prototypes/Maps/Pools/default.yml` at line 52, This change modifies
a YAML file outside /ADT/ without the required marker — add an explicit
ADT-Tweak annotation: for this single-line edit insert a comment using "#
ADT-Tweak: <brief reason>" immediately adjacent to the modified line (or wrap
multiple edits with "# ADT-Tweak-Start" and "# ADT-Tweak-End"); reference the
ADT-Tweak token and ensure the brief reason explains why the change to the line
"ADT_Barratry Выведена по просьбе Жабича" is needed.

@Inconnu1337
Copy link
Copy Markdown
Collaborator

image

@Cethet
Copy link
Copy Markdown
Contributor Author

Cethet commented May 20, 2026

до слез

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: Map Изменение карт Changes: No C# size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants