Skip to content

Use design tokens for notification badge colors #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vku2018 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

Use design tokens for notification badge colors #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/frontend/app/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
--db-on-surface-variant: #c5c9ae;
--db-primary-container: #c8f232;
--db-on-primary: #293500;
--db-danger: #ffb4ab;
--db-on-danger: #690005;
--db-outline-variant: #444934;

--font-geist: var(--font-geist-sans);
Expand Down
9 changes: 6 additions & 3 deletions apps/frontend/components/notifications/notification-bell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export type NotificationBellVariant = "landing" | "dashboard";
type VariantClasses = {
button: string;
buttonHover: string;
badgeBg: string;
badgeText: string;
panel: string;
panelHeaderBorder: string;
Expand All @@ -31,7 +32,8 @@ type VariantClasses = {
const LANDING_VARIANT: VariantClasses = {
button: "relative text-on-surface-variant",
buttonHover: "hover:text-on-surface",
badgeText: "text-[#293500]",
badgeBg: "bg-[var(--db-danger)]",
badgeText: "text-[var(--db-on-danger)]",
panel: "bg-surface-container border-outline-variant",
panelHeaderBorder: "border-outline-variant",
panelHeaderTitle: "text-on-surface",
Expand All @@ -55,7 +57,8 @@ const DASHBOARD_VARIANT: VariantClasses = {
"relative flex size-11 items-center justify-center rounded text-[var(--dash-muted)]",
buttonHover:
"hover:text-[var(--dash-heading)] hover:bg-[var(--dash-surface)]",
badgeText: "text-[var(--dash-on-accent-strong)]",
badgeBg: "bg-[var(--dash-danger)]",
badgeText: "text-[var(--dash-on-danger)]",
panel: "bg-[var(--dash-surface)] border-[var(--dash-border)]",
panelHeaderBorder: "border-[var(--dash-border)]",
panelHeaderTitle: "text-[var(--dash-heading)]",
Expand Down Expand Up @@ -184,7 +187,7 @@ export function NotificationBell({ variant, className }: NotificationBellProps)
{unreadCount > 0 && (
<span
aria-hidden="true"
className={`absolute right-1 top-1 inline-flex min-w-[18px] items-center justify-center rounded-full bg-[var(--db-danger,#ff5470)] px-1 text-[10px] font-bold leading-[14px] ${v.badgeText}`}
className={`absolute right-1 top-1 inline-flex min-w-[18px] items-center justify-center rounded-full px-1 text-[10px] font-bold leading-[14px] ${v.badgeBg} ${v.badgeText}`}
>
{unreadCount > 9 ? "9+" : unreadCount}
</span>
Expand Down