Skip to content

Correct code samples#332

Merged
meker12 merged 6 commits intomainfrom
DATA-7048-fix-categories-devdocs
Mar 17, 2026
Merged

Correct code samples#332
meker12 merged 6 commits intomainfrom
DATA-7048-fix-categories-devdocs

Conversation

@meker12
Copy link
Copy Markdown
Contributor

@meker12 meker12 commented Mar 12, 2026

Purpose of this pull request

Fixes inaccurate level values and misleading examples in the Categories Storefront Implementation page. Category hierarchy levels were using 0-based indexing when the API uses 1-based levels. The root categories example was also restructured to better reflect the discovery-first query pattern, and a redundant depth: 0 example was removed in favor of a more accurate explanation of how depth and level interact.

Staging preview

Affected pages

@meker12 meker12 self-assigned this Mar 12, 2026
@meker12 meker12 added the technical Changes to code, examples, or technical processes label Mar 12, 2026
@github-project-automation github-project-automation bot moved this to 📋 Needs Review in Commerce - Pull Requests Mar 12, 2026
meker12 added 2 commits March 12, 2026 14:34
  in enhanced-schema.json (family, slugs, depth) — removing verbose
  markdown-formatted prose in favour of concise plain-text descriptions
- Remove duplicate FIELD_ARGUMENT block from metadata-merchandising.json
  now that argument descriptions are owned by enhanced-schema.json
- Streamline categories-storefront-implementation.md by folding the
  standalone CategoryViewV2 section into the Category types intro,
  removing performance safeguard subsections, and minor wording fixes
- Rebuild static merchandising API HTML to reflect updated descriptions
- fix: simplify category API docs and use dynamic API host configuration
- Replace hardcoded na1-sandbox host in config-merchandising.yml with
  ${API_HOST} environment variable for portability across environments
@meker12 meker12 marked this pull request as ready for review March 13, 2026 21:04
@meker12 meker12 requested a review from mslabko March 13, 2026 21:09
@github-project-automation github-project-automation bot moved this from 📋 Needs Review to 👍 Approved in Commerce - Pull Requests Mar 13, 2026
Co-authored-by: Margaret Eker <meker@adobe.com>
@meker12 meker12 merged commit fbbf0df into main Mar 17, 2026
11 checks passed
@meker12 meker12 deleted the DATA-7048-fix-categories-devdocs branch March 17, 2026 17:16
@github-project-automation github-project-automation bot moved this from 👍 Approved to 🏁 Done in Commerce - Pull Requests Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical Changes to code, examples, or technical processes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants