Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpClientFactory: Expose a method to customize the underlying #3206

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Nov 10, 2023

HttpClient

Cleanup javadoc
This closes #3205

@kwin kwin requested a review from davidjgonzalez November 10, 2023 18:52
@kwin kwin force-pushed the feature/customizable-httpclientfactory branch from 40551e0 to 20bccf9 Compare November 10, 2023 18:53
@kwin kwin force-pushed the feature/customizable-httpclientfactory branch from 4429da0 to dc3be94 Compare November 15, 2023 18:25
@kwin kwin added this to the 6.3.2 milestone Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (4a43485) 55.23% compared to head (583990c) 55.19%.

Files Patch % Lines
...e/acs/commons/http/impl/HttpClientFactoryImpl.java 47.36% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3206      +/-   ##
============================================
- Coverage     55.23%   55.19%   -0.04%     
+ Complexity     5469     5468       -1     
============================================
  Files           720      720              
  Lines         29497    29502       +5     
  Branches       3837     3838       +1     
============================================
- Hits          16293    16284       -9     
- Misses        11681    11693      +12     
- Partials       1523     1525       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kwin added 2 commits November 15, 2023 20:31
Add nameHint for web console
@kwin kwin force-pushed the feature/customizable-httpclientfactory branch from dc3be94 to 74fee01 Compare November 15, 2023 19:31
@davidjgonzalez davidjgonzalez merged commit 9548124 into master Nov 15, 2023
9 of 17 checks passed
@davidjgonzalez davidjgonzalez deleted the feature/customizable-httpclientfactory branch November 15, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpClientFactory: Expose a method to customize the underlying HttpClient
2 participants