Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Java 11 for building #3109

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Require Java 11 for building #3109

merged 1 commit into from
Nov 15, 2023

Conversation

kwin
Copy link
Contributor

@kwin kwin commented May 17, 2023

This closes #3108

@kwin kwin requested a review from davidjgonzalez May 17, 2023 18:10
@kwin kwin force-pushed the feature/drop-java8-build-support branch from 088b871 to b45dae4 Compare May 17, 2023 18:10
@codecov
Copy link

codecov bot commented May 17, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a57b4db) 55.23% compared to head (80a1f82) 55.23%.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #3109   +/-   ##
=========================================
  Coverage     55.23%   55.23%           
  Complexity     5469     5469           
=========================================
  Files           720      720           
  Lines         29497    29497           
  Branches       3837     3837           
=========================================
  Hits          16293    16293           
  Misses        11681    11681           
  Partials       1523     1523

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidjgonzalez davidjgonzalez added the Skip-Changelog Skips the check for a changelog entry in the CI build label Jun 2, 2023
@kwin kwin marked this pull request as draft June 11, 2023 08:57
@kwin
Copy link
Contributor Author

kwin commented Jun 11, 2023

In order to still execute UTs/ITs with Java 8, Maven Toolchains should be used together with m-surefire-p/m-failsafe-p.

@davidjgonzalez
Copy link
Contributor

@kwin is this ready for review/merge?

@kwin
Copy link
Contributor Author

kwin commented Aug 8, 2023

Currently it will drop testing (i.e. run ITs) with Java 8 but I don't think this is really required...
Testing with Java 8 requires more tweaking on the GitHub Actions.

@kwin kwin marked this pull request as ready for review August 9, 2023 12:35
@kwin kwin force-pushed the feature/drop-java8-build-support branch 2 times, most recently from 43df66c to 2d3743b Compare November 15, 2023 18:36
@kwin
Require Java 11 for building
80a1f82 
Drop Java8 profile (which makes cloud profile the only automatically
activated profile)
Build with JDK21 in addition

This closes #3108
@kwin kwin force-pushed the feature/drop-java8-build-support branch from 2d3743b to 80a1f82 Compare November 15, 2023 18:37
@kwin
Copy link
Contributor Author

kwin commented Nov 15, 2023

@davidjgonzalez This should be the last missing piece for also bringing the failing JDK8 back to green (as that was using the implicitly activated java8 profile which lead to the cloud profile no longer being active implicitly).

@kwin kwin merged commit af49ce1 into master Nov 15, 2023
13 of 19 checks passed
@kwin kwin deleted the feature/drop-java8-build-support branch November 15, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjgonzalez davidjgonzalez davidjgonzalez approved these changes

Assignees
No one assigned
Labels
Skip-Changelog Skips the check for a changelog entry in the CI build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Require Java 11 for building
2 participants
@kwin @davidjgonzalez