Implement SNS:PublishBatch #274
Conversation
|
ref #270 |
app/gosns/gosns.go
Outdated
| } | ||
|
|
||
| // StringListValue and BinaryListValue is currently not implemented | ||
| for _, valueKey := range [...]string{"StringValue", "BinaryValue"} { |
There was a problem hiding this comment.
If someone provided both StringValue and BinaryValue would we overwrite StringValue? If so, is that what we want?
There was a problem hiding this comment.
Reading the docs this needs refinement. I took this from the SNS:Publish (gosns.Publish) implementation (which may also need some rework I'm not going to touch it here).
There was a problem hiding this comment.
EDIT: Correction, the SNS docs are unclear on the behaviour here. I'll do what the localstack solution does...
There was a problem hiding this comment.
Sounds good, I like your pattern here better anyway - it's clearer about what we're doing. We can dig deeper on how exactly it's supposed to work later.
|
Last commit requires #277 |
|
Hm, I think we're close here - looks like the tests are failing on |
|
@perrydunn quick follow up here. Any thoughts on this? |
|
Hi, is this issue resolved now that #314 has merged? Additionally, are there any plans for these changes to be released? |
tests to be added
(already using with a project successfully)