fix: sync CR feedback from upstream PRs#82
Merged
Adi1231234 merged 4 commits intomain-with-fixes-and-logsfrom Mar 20, 2026
Merged
fix: sync CR feedback from upstream PRs#82Adi1231234 merged 4 commits intomain-with-fixes-and-logsfrom
Adi1231234 merged 4 commits intomain-with-fixes-and-logsfrom
Conversation
- PR wwebjs#22449: dynamic ADV key via WAWebUserPrefsMultiDevice (closure bug fix), cancelPairingCode uses WAWebLaunchSocketUtils + WAWebAltDeviceLinkingApi - PR wwebjs#201653: remove unnecessary try/catch around obj.off() - PR wwebjs#182677: remove try/catch from isPlaceholderMessageResendEnabled - upstream: rename WAWebGroupQueryJob to WAWebGroupInviteJob in acceptInvite
syncs PR wwebjs#201660 fix that was missing from main-with-fixes-and-logs. store.save() was using path.join(this.dataPath, this.sessionName) which caused sessions to be saved under the local filesystem path as remote key.
Adi1231234
force-pushed
the
fix/sync-upstream-pr-feedback-logs
branch
from
c14b696 to
74e1fac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WAWebUserPrefsMultiDevice.getADVSecretKey()instead of stale closure capture.cancelPairingCode()now usesWAWebLaunchSocketUtils.refreshQR()+WAWebAltDeviceLinkingApi.initializeQRLinking()instead of deprecatedAuthStore.PairingCodeLinkUtils. Removes unusedwindow.getQRglobal and QR listener cleanup onchange:hasSynced.obj.off()in listener cleanup.isPlaceholderMessageResendEnabledgate override (ciphertext batching + failTimer guard already synced).WAWebGroupQueryJobtoWAWebGroupInviteJobinacceptInviteto match upstream main.Note: framenavigated try/catch blocks preserved in this branch because they contain diagnostic logging.
Test plan
cancelPairingCode()switches back to QR mode correctlyacceptInviteworks with the renamed module