Skip to content

[trello.com/c/SL4zLZnb] Show "❌" when the transaction is failed instead of clock image #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release/3.11.0
Choose a base branch
from
Open

[trello.com/c/SL4zLZnb] Show "❌" when the transaction is failed instead of clock image #884

wants to merge 1 commit into from

Conversation

Lainaaa
Copy link
Collaborator

@Lainaaa Lainaaa commented Jun 18, 2025

No description provided.

@Lainaaa Lainaaa requested a review from vovameister June 18, 2025 14:11
@Lainaaa Lainaaa self-assigned this Jun 18, 2025
vovameister
vovameister reviewed Jun 20, 2025
View reviewed changes
Copy link
Member

@vovameister vovameister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you use static let and TransactionDetailsViewControllerBase.failedValueString instead of common let and self?.failedValueString?

@Lainaaa
Copy link
Collaborator Author

Lainaaa commented Jun 23, 2025

why do you use static let and TransactionDetailsViewControllerBase.failedValueString instead of common let and self?.failedValueString?

I just followed existed code style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vovameister vovameister vovameister approved these changes

Assignees

@Lainaaa Lainaaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lainaaa @vovameister