Cheetahs - Alexis Miller #125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbieniosek
reviewed
Nov 28, 2022
| description = db.Column(db.String(2600)) | ||
| completed_at = db.Column(db.DateTime, nullable=True) | ||
|
|
||
| def to_dict(self): |
|
|
||
|
|
||
| #Validate | ||
| def validate_task(task_id): |
| request_body = request.get_json() | ||
|
|
||
| if "title" not in request_body or "description" not in request_body: | ||
| return jsonify({"details": "Invalid data"}), 400 |
| for task in tasks: | ||
| task_response.append(task.to_dict()) | ||
|
|
||
| return jsonify(task_response) |
There was a problem hiding this comment.
Even though Flask will add the 200 for you, I recommend being explicit about the code everywhere, and not just in non 200 returns. Consistent formats make code easier to read.
Suggested change
| return jsonify(task_response) | |
| return jsonify(task_response), 200 |
|
|
||
| task = validate_task(task_id) | ||
|
|
||
| return make_response({"task": task.to_dict()}) |
There was a problem hiding this comment.
The function make_response isn't incorrect here, but I notice that some functions return jsonify and others return make_response. I recommend picking one format and using it throughout your code - having different formats that do the same thing can make it harder for someone reading your code to realize that the behavior is the same.
| def mark_complete(task_id): | ||
| task = validate_task(task_id) | ||
|
|
||
| task.completed_at = date.today() |
| # **Complete test with assertion about response body*************** | ||
| # ***************************************************************** | ||
|
|
||
| assert response_body == {"message" : "Task ID '1' not found"} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.