Tigers Kindra Greenawalt #122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spitsfire
reviewed
Jan 9, 2023
spitsfire
left a comment
spitsfire
left a comment
There was a problem hiding this comment.
Nice going, Kindra! Consider changing a couple of pieces based on feedback and you wave 03 test will pass!
| const newChatMessage = [...entries]; | ||
| for (let i = 0; i < newChatMessage.length; i++) { | ||
| const message = newChatMessage[i]; | ||
| if (ChatEntry.id === id) { |
There was a problem hiding this comment.
Is this supposed to be ChatEntry? This suggests it is a component. Did you mean message.id?
There was a problem hiding this comment.
Wave 3 isn't passing because no hearts are ever successfully updated because of the wrong variable.
| } | ||
| setEntries(newChatMessage); | ||
| }; | ||
| const likedTotal = (entries) => { |
Comment on lines
+42
to
+46
| {/* // sender="Joe Biden" | ||
| // body="Get out by 8am. I'll count the silverware" | ||
| // timeStamp="2018-05-18T22:12:03Z" | ||
| // entries={entries} | ||
| // onUpdateLikeCount={updateLikeCount} */} |
There was a problem hiding this comment.
Let's just remove this completely
Suggested change
| {/* // sender="Joe Biden" | |
| // body="Get out by 8am. I'll count the silverware" | |
| // timeStamp="2018-05-18T22:12:03Z" | |
| // entries={entries} | |
| // onUpdateLikeCount={updateLikeCount} */} |
| <div id="App"> | ||
| <header> | ||
| <h1>Application title</h1> | ||
| <h1>Application title ❤️ {totalLikeTally}</h1> |
There was a problem hiding this comment.
Wave 3 test isn't passing because it expects to find specific text: 3 ❤️s based on the test. So to replicate this, the text should be something like {totalLikeTally} ❤️s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.