Skip to content

Conversation

@OhCloud
Copy link

@OhCloud OhCloud commented Feb 24, 2020

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, you hit the basic learning goals, with some issues on space/time complexity. Check out my comments and let me know if you have any questions.

Nice job here Cloudy!

return current_node
end

def add(key, value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space/time complexity?

Comment on lines 76 to 78
# Time Complexity:
# Space Complexity:
def find(key)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big O?

# Space Complexity:
def inorder
raise NotImplementedError
def inorder #return [] with order were given

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 except for bigO


# Time Complexity:
# Space Complexity:
def preorder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 except for bigO


# Time Complexity:
# Space Complexity:
def postorder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 except for bigO




def height_helper(current_node)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 except for bigO. nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants