Branches - Monick #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Feb 23, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, you hit all the learning goals here. Well done. Take a look at my comments and let me know if you have questions. The methods you have written all work and you've demonstrated an understanding of how to implement a Linked List.
|
|
||
| # method to find if the linked list contains a node with specified value | ||
| # returns true if found, false otherwise | ||
| def search(value) |
| def find_max | ||
| raise NotImplementedError | ||
| return nil if @head.nil? | ||
| max = 0 |
There was a problem hiding this comment.
What if it's a linked list of negative values, or non-integers?
Suggested change
| max = 0 | |
| max = @head.data |
|
|
||
| # method to return the min value in the linked list | ||
| # returns the data value and not the node | ||
| def find_min |
|
|
||
|
|
||
| # method that returns the length of the singly linked list | ||
| def length |
| def length | ||
| raise NotImplementedError | ||
| count = 0 | ||
| return count if @head.nil? |
|
|
||
| # method to reverse the singly linked list | ||
| # note: the nodes should be moved and not just the values in the nodes | ||
| def reverse |
Comment on lines
+163
to
+166
| until current.next.nil? | ||
| length += 1 | ||
| current = current.next | ||
| end |
There was a problem hiding this comment.
Why not use the length method to calculate the length of the list?
| # Additional Exercises | ||
| # returns the value in the first node | ||
| # returns nil if the list is empty | ||
| def get_first |
| end | ||
|
|
||
| # method that inserts a given value as a new last node in the linked list | ||
| def add_last(value) |
|
|
||
| # method that returns the value of the last node in the linked list | ||
| # returns nil if the linked list is empty | ||
| def get_last |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.