Ports -Margaret #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functionality not working yet
piffer59
reviewed
Jun 11, 2019
piffer59
left a comment
piffer59
left a comment
There was a problem hiding this comment.
I like how you organized your code. I found it easy to read and it looks great! Nice work!
| <TimelineEvent key={i} | ||
| person={event.person} | ||
| status={event.status} | ||
| time={event.timeStamp} /> |
There was a problem hiding this comment.
I like how you spaced these out, it makes it easy to read
| <h1 className="App-title">Ada Lovelace's social media feed</h1> | ||
| </header> | ||
| <main className="App-main"> | ||
| <Timeline events={timelineData.events} /> |
| <div className="event-timestamp"> | ||
| <Timestamp time={props.time} /> | ||
| </div> | ||
| </section> |
There was a problem hiding this comment.
I like that these are in div elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Timeline
Congratulations! You're submitting your assignment!
Comprehension Questions