Heather #9
Open
Heather #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Oct 17, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, you hit all the time and space complexities and solved both problems using a dynamic programming approach. Your newman conway solution could use some simplification. Overall well done.
|
|
||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(1), where n is the number of elements in the array |
There was a problem hiding this comment.
Constant? Really? No this is O(n) time complexity.
Comment on lines
+17
to
+31
| if num < 2 | ||
| series[1..num].each do |num| | ||
| series_string += "#{num} " | ||
| end | ||
| else | ||
| until counter == num | ||
| counter += 1 | ||
| p_next = series[series[counter - 1]] + series[counter - series[counter - 1]] | ||
| series << p_next | ||
| end | ||
|
|
||
| series[1..-1].each do |num| | ||
| series_string += "#{num} " | ||
| end | ||
| end |
There was a problem hiding this comment.
This definitely works, but could be simplified a bit. I don't think you need the if statement if already have the series array set up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.