Niv #5
Open
Niv #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Oct 17, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Take a look at my comments on the newman conway sequence. Then review the notes on Fibonacci sequence. You did things in a very inefficient manner. See if you can identify why.
Max subarray was well done.
| if num < 3 | ||
| return 1 | ||
| else | ||
| num = get_newman_num(get_newman_num(num - 1)) + get_newman_num(num - get_newman_num(num - 1)) |
There was a problem hiding this comment.
Because you're not saving the subproblems anywhere, you end up solving the problems over and over like Fibonacci sequence. So this is MUCH worse than O(n). I believe this is actually O(3n) since you are making 3 recursive calls at each level.
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def max_sub_array(nums) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.