Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions lib/max_subarray.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,24 @@

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def max_sub_array(nums)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return 0 if nums == nil

raise NotImplementedError, "Method not implemented yet!"
return nil if nums.empty?
max_so_far = nums.max

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need this?

if max_so_far < 0
return max_so_far
end
max_ending_here = 0

nums.each do |num|
max_ending_here = max_ending_here + num

if max_ending_here < 0
max_ending_here = 0
end
if max_so_far < max_ending_here
max_so_far = max_ending_here
end
end
return max_so_far
end
23 changes: 18 additions & 5 deletions lib/newman_conway.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,20 @@


# Time complexity: ?
# Space Complexity: ?
def newman_conway(num)
raise NotImplementedError, "newman_conway isn't implemented"
end
# Time complexity: O(n)
# Space Complexity: O(n)


def newman_conway(nums)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

result = Array.new()
raise ArgumentError if nums == 0
return "1" if nums == 1
result[1] = 1
result[2] = 1
if nums > 2
(3..nums).each do |num|
result[num] = result[result[num - 1]] + result[num - result[num - 1]]
end
end
result.delete_at(0)
return result.join(" ")
end
2 changes: 1 addition & 1 deletion test/max_sub_array_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative "test_helper"

xdescribe "max subarray" do
describe "max subarray" do
it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do
# Arrange
input = [-2,1,-3,4,-1,2,1,-5,4]
Expand Down