Angela #10
Open
Angela #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Oct 17, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
You didn't take a dynamic programming approach to these solutions at all. Take a look at my notes and when we review this in class. Memoization as an approach can greatly improve the time complexity of these algorithms.
Comment on lines
+12
to
+24
| while i < size | ||
| max_ending_here = 0 | ||
| j = i | ||
| while j < size | ||
| max_ending_here = max_ending_here + nums[j] | ||
| if max_so_far < max_ending_here | ||
| max_so_far = max_ending_here | ||
| end | ||
| j += 1 | ||
| end | ||
| i += 1 | ||
| end | ||
| return max_so_far |
There was a problem hiding this comment.
Think about how you could use a dynamic programming approach (saving max subarrays) to avoid having this inner loop.
Comment on lines
+23
to
26
| def newman_conway_helper(num) | ||
| return 1 if num == 1 || num == 2 | ||
| return newman_conway_helper( newman_conway_helper(num - 1)) + newman_conway_helper(num - newman_conway_helper(num - 1)) | ||
| end |
There was a problem hiding this comment.
This is exactly the same problem as fibonacci. Please re-read the textbook curriculum on this. Your solution is O(3n), which is much worse than the linear time solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.