Ports - Kasey

[kaseea]

No description provided.

[cyndilopez]

This looks good to me! I like where you checked if both input arrays were nil or empty arrays...I didn't think of that.

[ace-n]

👍 LGTM other than a few style nits. 😄

[ace-n]

Good boundary checking!

Style nit: this many if-statements all in one line is a bit confusing. (You have to know Ruby's order of operations in order to understand it. 😄 )

• Good: use parenthesis around the "and" clauses (e.g. if (array1 == nil && array2 == nil) || (array1 == [] && array2 == []))
• Better: break up each condition (e.g. == nil and == []) into separate "guarding" if-statements

e.g.

# Null/empty checks
if array1 == nil && array2 == nil
  return true
elsif array1 == [] && array2 == []
  return true
elsif array1 == nil || array2 == nil
  return false

# Length check
if array1.length != array2.length
  return false
end

...

You might even be able to do this - but some people would say this
is not explicit enough (or "has too much magic")

if array1 == array2:
  return True
elsif array1 == nil || array2 == nil:
  return False
elsif array1 == [] || array2 == []:
  return False
end

[ace-n]

Nit: this block shouldn't be nested inside an else (because the else is redundant here).

[ace-n]

Nit: .each iterates through arrays in order in Ruby, but may not for other data types

Would this break if (for whatever reason) .each did its iteration out of order? If so, how might we fix that?