Ports -- Kate

[goblineer]

No description provided.

[aphunk]

Nice job! Our approach is very similar. I realized after I submitted it that it can be a lot less verbose, but this makes a lot of sense when using the test results to solve the problem.

[ace-n]

FYI: ask a TA about using git push --force, which should (hopefully) solve the merge issues.

Warning: be very careful with this command, as it can permanently delete git history. (It's pretty much the most dangerous git command there is 😨- but is largely harmless once you know how to use it. 🙂)

[ace-n]

(Was able to find your code here.)

LGTM other than a style nit or two. 👍 Can you add complexity analysis as well? 🙂

[ace-n]

Nit: these if statements are a bit redundant - how about combining some of them, e.g:

if (array1 == nil && array2 == nil) {
  return true;
} elsif (array1 == nil || array2 == nil) {
  return false;
}
...

[ace-n]

Tiny nit: the else is redundant here. You can move this inner block out of it. 🙂