Sockets - Jansen #30
Open
Sockets - Jansen #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While you commented that my if/else was shorter I really like how you can quickly see the logic that you used. Each case that we needed to address with tests has a specific section of your solution. I would encourage you to not be shy around the AND and OR operators, but it is clear that you have a great understanding of how they work. :) |
jadevance
reviewed
Apr 9, 2019
| return false | ||
| end | ||
| end | ||
| return true |
There was a problem hiding this comment.
Nice job on your logic! Your code is clear and easy to understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.