Skip to content

Sockets- Kate N #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KateAnnNichols wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sockets- Kate N #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/binary_to_decimal.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,9 @@
# the algorithm you devised in class.
def binary_to_decimal(binary_array)
raise NotImplementedError
decimal = 0
8.times do |i|
Copy link

@ChubbyCub ChubbyCub Mar 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with the do ... loop. Can you think of a way to generalize the algorithm so that it works for n bits?

decimal += binary_array[i] * 2 ** (7 - i)
Copy link

@ChubbyCub ChubbyCub Mar 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with using the math operator **. Can you think of a faster way to perform this without having to use the ** operation? Your code currently requires recalculating 2 to the power of n (number of bits) at every iteration.

end
return decimal
end