Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): pynput needs python 3.13 #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Game4Move78
Copy link

@Game4Move78 Game4Move78 commented Feb 6, 2025

Internal changes to the Python threading library in 3.13 breaks pynput. Likely to be fixed when fixup/listener-thread-handle is merged, but at the moment Python 3.13 will throw this error:

2024-12-26 15:58:58 [ERROR]: Unhandled exception in listener callback  (pynput.mouse.Listener:233)
Traceback (most recent call last):
  File "/usr/lib/python3.13/site-packages/pynput/_util/__init__.py", line 229, in inner
    return f(self, *args, **kwargs)
  File "/usr/lib/python3.13/site-packages/pynput/_util/xorg.py", line 470, in _handler
    self._handle(self._display_stop, event)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: '_thread._ThreadHandle' object is not callable

Related to activitywatch#1122, pynput#614


Important

Update Python version constraint in pyproject.toml to exclude 3.13 due to pynput compatibility issue.

  • Dependencies:
    • Update Python version constraint in pyproject.toml to ^3.8,<3.13 due to pynput compatibility issue with Python 3.13.
    • Reference issue pynput#614 for more details.

This description was created by Ellipsis for 1f5ac1f. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 1f5ac1f in 21 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pyproject.toml:13
  • Draft comment:
    The version constraint '^3.8,<3.13' correctly prevents Python 3.13 usage due to pynput issues. Ensure to update this once the upstream fix is merged.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is purely informative, explaining the reason behind a version constraint. It doesn't provide a specific code suggestion or ask for a test to be written. It also doesn't ask for confirmation of intention or any other action from the PR author.
2. pyproject.toml:13
  • Draft comment:
    Restricting Python version to <3.13 is a good temporary workaround for the pynput issue. Consider adding a note linking the expected fix branch (e.g., fixup/listener-thread-handle) so it's easier to revert this when the issue is resolved.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_4wCZaK646s5X0HVY


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant