Skip to content

Commit

Permalink
ci: downgrade to Python 3.9 (#941)
Browse files Browse the repository at this point in the history
  • Loading branch information
ErikBjare authored Aug 30, 2023
1 parent de9dbad commit c9e4d11
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
16 changes: 11 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-20.04, windows-latest, macOS-12]
python_version: [3.11]
python_version: [3.9]
node_version: [16]
skip_rust: [false]
skip_webui: [false]
Expand Down Expand Up @@ -62,15 +62,21 @@ jobs:
- name: Set up Python for macOS
if: runner.os == 'macOS'
run: |
# macos11 seems to suggest it only supports macos11 and up, but the release page says "for macOS 10.9 and later"
curl https://www.python.org/ftp/python/${PYTHON_VERSION}/python-${PYTHON_VERSION}-macosx10.9.pkg -o "python.pkg"
# Python 3.11+ only has *macos11.pkg, so no more *macosx10.9.pkg
# the 'macos11' naming seems to suggest it only supports macos11 and up,
# but the release page says "for macOS 10.9 and later",
# unclear what the resulting binary compatibility will be.
curl https://www.python.org/ftp/python/${PYTHON_VERSION}/python-${PYTHON_VERSION}-macos11.pkg -o "python.pkg"
#
# curl https://www.python.org/ftp/python/${PYTHON_VERSION}/python-${PYTHON_VERSION}-macos11.pkg -o "python.pkg"
sudo installer -pkg python.pkg -target /
echo "/Library/Frameworks/Python.framework/Versions/${{ matrix.python_version }}/bin" >> $GITHUB_PATH
"/Applications/Python ${{ matrix.python_version }}/Install Certificates.command"
env:
# Add the patch number to the Python version (for FTP download link)
PYTHON_VERSION: ${{ matrix.python_version }}.4
PYTHON_VERSION: ${{ matrix.python_version }}.13

- name: Set up Node
if: ${{ !matrix.skip_webui }}
Expand Down Expand Up @@ -240,7 +246,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: ">=3.11"
python-version: "3.9"

- name: Install deps
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
if: ${{ env.new_version == 'this' }}
uses: actions/download-artifact@v3
with:
name: builds-Linux-py3.11
name: builds-Linux-py3.9
path: dist

# Only used during testing, so we don't have to wait for the main build job
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
poetry 1.5.1
nodejs 16.20.2
rust nightly
python 3.11.4
python 3.9.13

0 comments on commit c9e4d11

Please sign in to comment.